私のコードは、ユーザーに作成したいディレクトリの名前を入力するように指示し、ディレクトリ内のファイルを編集するように求めるメッセージを表示する必要がありますが、ディレクトリを作成した後はスクリプトが続行されず、エラーは表示されません。しかし、新しい目でコードを批判することは常に簡単です。
また、ディレクトリにファイルを追加しますが、編集するかどうかを尋ねません。
#!/bin/bash
#Testing to see if input is empty
if [ $# -lt 1 ]; then
echo "Empty Directory will be created"
fi
#Get the name of the directory by the user, also creating a variable named directory
read -p "Please enter the name of the drectory you wish to create: " directory
#Check if the directory exists, if it doesn't it will be created in the Home folder
if [ ! -d ~/$directory ]; then
#Creating the directory if it doesnt exist
mkdir ~/$directory/
fi
#Create files individually in the directory
for i in "$@"; do
touch ~/$directory/$i
#Asking the user if they wish to edit the files they have created inside the directory
read -p "edit file $i (Y/N)? " edit
#If they answer yes then read the lines entered by the user
if [["$edit" = "Y" || "$edit" = "y"]]; then
line=""
#Stores the amount of words added to the file
count=0
#Reads the lines enetered by the user
echo "Please enter your text to be added into the file (Enter \"end\" to exit the editing):"
read line
#The script will keep reading the words entered in the file until the user initiates the end command "end"
while ["$line" != "end"]; do
#repeat the words entered into the file
echo "$line" >> ~/directory/$i
#Get the amount of words entered into the file
count=$(($count + $(wc -w <<< $line)))
#read the next line from user input
read line
done
echo "$count words have been written to the file"
fi
done
答え1
この行を変更してください
if [["$edit" = "Y" || "$edit" = "y"]]; then
この行を使用すると:
if [[ "$edit" = "Y" || "$edit" = "y" ]]; then
[[]]の後にスペースはありません。
また、〜の代わりに$ HOMEを使用する方が良いです。